You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The require-return-after-core-setfailed ESLint rule has a soundness gap: it only scans statement lists (BlockStatement.body, SwitchCase.consequent, Program.body), so braceless if/else/loop consequents like:
if(bad)core.setFailed("x");doMore();// NOT caught by rule
...are never checked, while braced equivalents are correctly caught. Although there are currently 0 live braceless sites, this is a latent soundness gap that will silently miss real violations as the codebase grows.
Suggested Changes
Update require-return-after-core-setfailed rule implementation to handle braceless consequents in IfStatement, ElseStatement, and loop bodies
Add test cases to the rule's test suite covering braceless if with setFailed without a following return
Verify the existing test cases still pass
Files Affected
actions/setup/js/ — ESLint rule source for require-return-after-core-setfailed
Corresponding test file for this rule
Success Criteria
Braceless if (cond) core.setFailed(msg); continueExecution(); is flagged by the rule
Activity
github-actions commentedon Jul 15, 2026
This issue was automatically closed because it expired on 2026-07-15T07:37:05.011Z.