Skip to content

[deep-report] Add GitHubMCPMode string enum and reduce githubTool any params in mcp_github_config.go #38868

Closed as not planned

Description

@github-actions

Description

The Typist analysis flagged a small type-safety cluster in pkg/workflow/mcp_github_config.go: ~19 githubTool any parameters that always immediately assert to map[string]any, plus a missing GitHubMCPMode string enum for the MCP mode values that are currently passed as bare strings. Stronger types here remove repeated type assertions and make valid modes self-documenting.

Fix

  • Introduce a GitHubMCPMode string type with named constants for the accepted modes.
  • Replace the githubTool any params with a concrete map[string]any (or a small typed struct) to drop the per-call assertions.

Expected Impact

Fewer runtime type assertions, compile-time-checked MCP mode values, clearer API.

Suggested Agent

Typist / refactor agent.

Estimated Effort

Medium (1-2 h).

Data Source

DeepReport 2026-06-12; Typist analysis #38833.

Generated by 🔬 DeepReport - Intelligence Gathering Agent · 314.1 AIC · ⌖ 19.5 AIC · ⊞ 10.6K · ◷

  • expires on Jun 14, 2026, 7:56 AM UTC-08:00

Activity

  1. github-actions commented on Jun 14, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-06-14T15:56:01.415Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions