Repository navigation
Closed
Labels
Description
Objective
Fix shellcheck SC2086 (unquoted variable) warnings reported by actionlint in 15 workflows. Unquoted variables in shell scripts can cause word splitting and glob expansion bugs.
Context
Actionlint reported 24 shellcheck findings (primarily SC2086) across 15 workflows. Unquoted variables like $VAR instead of "$VAR" can cause bugs when the variable contains spaces or glob characters.
Reference: Static Analysis Report - 2026-04-11
Affected Workflows
.github/workflows/copilot-agent-analysis.md.github/workflows/copilot-pr-merged-report.md.github/workflows/copilot-pr-nlp-analysis.md.github/workflows/copilot-token-audit.md.github/workflows/copilot-token-optimizer.md.github/workflows/daily-issues-report.md.github/workflows/daily-news.md.github/workflows/deep-report.md.github/workflows/issue-arborist.md.github/workflows/prompt-clustering-analysis.md.github/workflows/release.md.github/workflows/smoke-claude.md.github/workflows/static-analysis-report.md- And 2 more workflows with shellcheck findings
Approach
For each affected .md file:
- Find
run:blocks containing unquoted variable references - Quote each variable: change
$VARto"$VAR"where appropriate - For SC2012 (use
findinstead ofls), replacelswithfindfor file listing - For SC2129 (use
>>instead of multiple>), consolidate redirect operations
Example fix for SC2086:
# Before (vulnerable to word splitting)
echo $MY_VAR
gh api $ENDPOINT
# After (safe)
echo "$MY_VAR"
gh api "$ENDPOINT"Steps
- For each affected
.mdfile, search for shellcheck annotations or unquoted variables inrun:blocks - Quote all unquoted variable references
- After all edits, run
make recompileto regenerate lock files - Run
make agent-finishto validate
Acceptance Criteria
- All SC2086 (unquoted variable) warnings resolved across affected workflows
- Other shellcheck findings (SC2012, SC2129) addressed where present
-
make recompilecompletes without errors -
make agent-finishpasses
Related to [static-analysis] Static Analysis Report - 2026-04-11 #25835
Generated by Plan Command for issue #25835 · ● 199.3K · ◷
- expires on Apr 13, 2026, 11:54 PM UTC
Reacted by Copilot
Activity