Repository navigation
Description
Description
The buildPreActivationJob() function in compiler_activation_jobs.go is 264 lines long and handles multiple concerns (setup, reactions, permissions, stop-time, skip-if-match, skip-if-no-match, commands). This makes it difficult to maintain and test individual behaviors.
Current State
File: pkg/workflow/compiler_activation_jobs.go
Function: buildPreActivationJob() (lines 17-281)
Size: 264 lines
Concerns handled:
- Setup and initialization
- Reaction step generation
- Permission configuration
- Stop-time validation
- Skip-if-match checks
- Skip-if-no-match checks
- Command validation
Suggested Changes
Extract logical sections into focused helper functions:
1. Extract Permission Configuration (15-20 lines)
func (c *Compiler) configurePreActivationPermissions(data *WorkflowData, needsContentsRead bool) *Permissions {
// Extract lines 44-62 from buildPreActivationJob
// Returns configured permissions for pre-activation job
}2. Extract Reaction Setup (20-30 lines)
func (c *Compiler) generateReactionStep(yaml *strings.Builder, data *WorkflowData) []string {
// Extract lines 66-85 from buildPreActivationJob
// Returns step IDs generated for reaction setup
}3. Extract Stop-Time Validation (30-40 lines)
func (c *Compiler) generateStopTimeValidation(yaml *strings.Builder, data *WorkflowData) []string {
// Extract stop-time check generation logic
// Returns step IDs for stop-time validation
}4. Extract Skip-If Validation (40-50 lines)
func (c *Compiler) generateSkipIfValidation(yaml *strings.Builder, data *WorkflowData) []string {
// Extract skip-if-match and skip-if-no-match logic
// Returns step IDs for skip validation
}Files Affected
pkg/workflow/compiler_activation_jobs.go(refactorbuildPreActivationJob)pkg/workflow/compiler_activation_jobs_test.go(add tests for new helper functions)
Success Criteria
buildPreActivationJob()function reduced to <100 lines- Each extracted function has single, clear responsibility
- All extracted functions have unit tests
- All existing tests continue to pass
- No change in compiled workflow output (behavior preserving refactor)
- Cyclomatic complexity reduced
Source
Extracted from Daily Compiler Code Quality Report - 2026-02-05
Specific recommendation:
Large Functions (Medium Priority)
buildPreActivationJob(): Lines 17-281 = 264 lines- Handles setup, reactions, permissions, stop-time, skip checks, commands
- Multiple concerns mixed together
- Immediate Actions (1-2 hours): Extract Permission Configuration, Extract Reaction Setup
Priority
Medium - Improves maintainability and testability without changing behavior. Should be addressed within 2-4 weeks to prevent further code complexity accumulation.
AI generated by Discussion Task Miner - Code Quality Improvement Agent
- expires on Feb 7, 2026, 1:28 AM UTC
Activity
github-actions commentedon Feb 7, 2026
This issue was automatically closed because it expired on 2026-02-07T01:28:12.271Z.