[Repo Assist] fix(rust-guard): remove dead .or_else() fallback in notifications arm

[github-actions]

🤖 This is an automated pull request from Repo Assist.

Closes #8921

Root Cause

In guards/github-guard/rust-guard/src/labels/response_items.rs, the list_notifications | get_notification_details arm had dead code:

let items = actual_response.as_array().or_else(|| response.as_array());

The .or_else(|| response.as_array()) fallback is always a no-op because extract_mcp_response (which produces actual_response) returns either:

• Cow::Owned(parsed) – parsed was successfully deserialized from content[0].text, so actual_response.as_array() is already Some(_); the fallback is unreachable.
• Cow::Borrowed(response) – actual_response is response, so .or_else(|| response.as_array()) checks the identical pointer twice.

This pattern is absent in every other arm of the same match block (they all call collect_items_simple(&actual_response) or extract_items_slice(&actual_response, ...) directly), making the notifications arm inconsistently defensive without benefit.

Fix

Remove the .or_else(...) chain, leaving the simpler:

let items = actual_response.as_array();

No behaviour change — the removed path was never executed.

Tests Added

The notifications arm previously had zero test coverage. Three tests are added:

Test	Covers
list_notifications_labels_each_item_as_private	private_user_label() secrecy assignment for each notification
list_notifications_description_includes_id	"notification:{id}" description format
get_notification_details_empty_array_returns_empty	empty array input → empty result

Test Status

✅ All 576 Rust tests pass (up from 573 before adding the new tests):

test result: ok. 576 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s

⚠️ Go unit tests blocked by network restrictions in this CI environment (pre-existing infrastructure issue — proxy.golang.org is inaccessible). This is a Rust-only change.

---

Generated by Repo Assist

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by Repo Assist · 716.4 AIC · ⊞ 10.8K · ◷
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

[Copilot]

Pull request overview

This PR simplifies Rust Guard item-labeling for GitHub notifications by removing an unreachable .or_else() fallback and adds targeted unit tests to cover the previously untested notifications arm in label_response_items.

Changes:

• Remove dead .or_else(|| response.as_array()) fallback in the notifications match arm.
• Add unit tests covering notification secrecy labeling, description formatting, and empty-array behavior.

Show a summary per file

File	Description
guards/github-guard/rust-guard/src/labels/response_items.rs	Removes unreachable fallback logic in notifications handling and adds new tests for notification labeling behavior.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Low