Skip to content

[Repo Assist] build(makefile): add -parallel=8 and -timeout flags to test targets#8934

Merged
lpcox merged 4 commits into
mainfrom
repo-assist/eng-makefile-test-consistency-20260714-edba210ed9f7bca7
Jul 8, 2026
Merged

[Repo Assist] build(makefile): add -parallel=8 and -timeout flags to test targets#8934
lpcox merged 4 commits into
mainfrom
repo-assist/eng-makefile-test-consistency-20260714-edba210ed9f7bca7

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 This is an automated pull request from Repo Assist.

Summary

Aligns test-unit, test-all, and test-integration with the flags already used in test-ci, fixing an inconsistency that caused slower local test runs and missing timeout guards.

Changes

Target Before After
test-unit go test -v ./internal/... go test -v -parallel=8 -timeout=3m ./internal/...
test-all go test -v ./... go test -v -parallel=8 -timeout=5m ./...
test-integration go test -v ./test/integration/... go test -v -timeout=5m ./test/integration/...

Motivation

  • test-unit lacked -parallel=8: Without parallelism, the Go test runner serialises test packages, adding several seconds to every local developer run. test-ci already uses -parallel=8.
  • test-unit and test-all lacked -timeout: A hung or deadlocked test would block indefinitely. test-race already uses -timeout=5m.
  • test-integration lacked -timeout: Integration tests that start real server processes could hang indefinitely.

Trade-offs

  • -parallel=8 parallelises across packages but keeps within-package test order serial; it is safe for this codebase which uses httptest.NewServer for isolation.
  • The 3-minute timeout for unit tests and 5-minute timeout for integration/all tests match existing CI practice.

Test Status

⚠️ Network restrictions active in this CI environmentgo mod tidy and go build require access to proxy.golang.org which is blocked. This is a pre-existing infrastructure limitation; the change is a pure Makefile text edit with no code logic changes.

The Makefile syntax was validated with make --dry-run test-unit (exit 0).


Generated by Repo Assist

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • awmgmcpg
  • proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by Repo Assist · 716.4 AIC · ⊞ 10.8K ·
Comment /repo-assist to run again

Add this agentic workflow to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

Align test-unit, test-all, and test-integration with the flags already
used in test-ci.  The changes are mechanical:

* test-unit: add -parallel=8 -timeout=3m to match test-ci behaviour.
  Without -parallel=8 the Go test runner serialises sub-tests across
  packages, adding several seconds to every local developer run.
  Without -timeout=3m a stuck test hangs indefinitely.
* test-all: same -parallel=8 -timeout=5m additions (longer timeout
  because it includes integration tests).
* test-integration: add -timeout=5m so a hung integration test does
  not block CI forever.

No logic changes; only flag additions to the go test invocations.

🤖 Generated by Repo Assist

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lpcox lpcox marked this pull request as ready for review July 8, 2026 13:45
Copilot AI review requested due to automatic review settings July 8, 2026 13:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Makefile test targets to add explicit -timeout guards (and to mirror the -parallel=8 usage already present in test-ci), aiming to make local runs more consistent with CI and avoid hangs.

Changes:

  • Add -timeout to test-unit, test-all, and test-integration.
  • Add -parallel=8 to test-unit and test-all to match test-ci’s flags.
  • Minor consistency update opportunity: standardize go test -timeout flag style across targets.
Show a summary per file
File Description
Makefile Adds -parallel/-timeout flags to multiple go test targets to align behavior and add timeout protection.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 3
  • Review effort level: Low

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Makefile Outdated
lpcox and others added 3 commits July 8, 2026 06:54
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants