[Repo Assist] build(makefile): add -parallel=8 and -timeout flags to test targets#8934
Merged
lpcox merged 4 commits intoJul 8, 2026
Conversation
Align test-unit, test-all, and test-integration with the flags already used in test-ci. The changes are mechanical: * test-unit: add -parallel=8 -timeout=3m to match test-ci behaviour. Without -parallel=8 the Go test runner serialises sub-tests across packages, adding several seconds to every local developer run. Without -timeout=3m a stuck test hangs indefinitely. * test-all: same -parallel=8 -timeout=5m additions (longer timeout because it includes integration tests). * test-integration: add -timeout=5m so a hung integration test does not block CI forever. No logic changes; only flag additions to the go test invocations. 🤖 Generated by Repo Assist Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Makefile test targets to add explicit -timeout guards (and to mirror the -parallel=8 usage already present in test-ci), aiming to make local runs more consistent with CI and avoid hangs.
Changes:
- Add
-timeouttotest-unit,test-all, andtest-integration. - Add
-parallel=8totest-unitandtest-allto matchtest-ci’s flags. - Minor consistency update opportunity: standardize
go test -timeoutflag style across targets.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds -parallel/-timeout flags to multiple go test targets to align behavior and add timeout protection. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Aligns
test-unit,test-all, andtest-integrationwith the flags already used intest-ci, fixing an inconsistency that caused slower local test runs and missing timeout guards.Changes
test-unitgo test -v ./internal/...go test -v -parallel=8 -timeout=3m ./internal/...test-allgo test -v ./...go test -v -parallel=8 -timeout=5m ./...test-integrationgo test -v ./test/integration/...go test -v -timeout=5m ./test/integration/...Motivation
test-unitlacked-parallel=8: Without parallelism, the Go test runner serialises test packages, adding several seconds to every local developer run.test-cialready uses-parallel=8.test-unitandtest-alllacked-timeout: A hung or deadlocked test would block indefinitely.test-racealready uses-timeout=5m.test-integrationlacked-timeout: Integration tests that start real server processes could hang indefinitely.Trade-offs
-parallel=8parallelises across packages but keeps within-package test order serial; it is safe for this codebase which useshttptest.NewServerfor isolation.Test Status
go mod tidyandgo buildrequire access toproxy.golang.orgwhich is blocked. This is a pre-existing infrastructure limitation; the change is a pureMakefiletext edit with no code logic changes.The
Makefilesyntax was validated withmake --dry-run test-unit(exit 0).Generated by Repo Assist
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
awmgmcpgproxy.golang.orgSee Network Configuration for more information.
Add this agentic workflow to your repo
To install this agentic workflow, run