Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The compiled parser source must be regenerated and committed for clean builds to include the fix.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates the Python extractor grammar to accept trailing commas in PEP 695 type parameter lists, addressing #22739.
Changes:
- Allows an optional trailing comma in the grammar.
- Adds parser fixtures for type aliases, functions, and classes.
| File | Description |
|---|---|
python/extractor/tsg-python/tsp/src/grammar.json |
Updates the generated grammar definition. |
python/extractor/tsg-python/tsp/grammar.js |
Allows trailing commas in type parameter lists. |
python/extractor/tests/parser/type_parameters_new.py |
Adds regression inputs for all three declaration forms. |
python/extractor/tests/parser/type_parameters_new.expected |
Records expected parser output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vibe coded by Copilot.
Trailing commas in PEP 695 type parameter lists are valid Python syntax and are emitted by formatters when a list is split across lines. Accept an optional trailing comma in the Tree-sitter grammar and add extractor parser coverage for type aliases, functions, and classes.
Fixes #22739
Testing
pytest -q tests/test_parser.py(39 passed)