C++: Fill gaps in query tests (part 1) - #22727
Conversation
…n.ql don't overlap (at least in the main case).
…block (exploring overlap).
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused test additions correctly exercise the intended query behavior and overlap boundaries.
Review effort: Balanced
Findings: None
What changed in this PR
Adds C++ query coverage to clarify overlap between related quality queries.
Changes:
- Adds tests for
cpp/empty-if. - Verifies overlap with
cpp/empty-block. - Confirms self-comparisons are not reported by
cpp/constant-comparison.
| File | Description |
|---|---|
FutileConditional/FutileConditional.qlref |
Configures the new query test. |
FutileConditional/FutileConditional.expected |
Records expected empty-if alerts. |
FutileConditional/FutileConditional.cpp |
Adds positive, negative, and known-missing cases. |
PointlessComparison/PointlessComparison.cpp |
Adds a non-overlap self-comparison case. |
EmptyBlock/EmptyBlock.expected |
Records additional empty-block results. |
EmptyBlock/empty_block.cpp |
Adds conditional branch overlap cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
LGTM. Two small comments, but it's fine with me to merge as-is.
| } | ||
| } | ||
|
|
||
| // BAD |
There was a problem hiding this comment.
Not for this PR, but did we forget to convert this test to an inline expectation test?
There was a problem hiding this comment.
This one's actually a pain to convert, because comments affect what is and isn't considered an empty block by the query. I decided it's best to leave it as not inline expectations.
There was a problem hiding this comment.
Oh, ouch, yeah you're right.
| if (value) { // good | ||
| ++value; | ||
| } | ||
|
|
||
| if (value) { // good |
There was a problem hiding this comment.
Nit: Do we want to capitalize "good" here to be consistent with what we do elsewhere?
Fill gaps in CPP query tests, with quality queries in mind:
cpp/comparison-of-identical-expressions(PointlessSelfComparison.ql) to the test forcpp/constant-comparison(PointlessComparison.ql); establishes no significant overlap in results.cpp/empty-if(FutileConditional.ql).cpp/empty-if(FutileConditional.ql) to the test forcpp/empty-block(EmptyBlock.ql); establishes significant overlap in results.