Repository navigation
Conversation
github-actions
Bot
changed the base branch from
main
to
mazze93/advisory-improvement-10184
October 6, 2026 07:05
This was referenced Oct 7, 2026
imkarrer
added a commit
to flox/floxenvs
that referenced
this pull request
Oct 12, 2026
Clears two Dependabot alerts in .flox/pkgs/iloom-cli, one of them critical: handlebars 4.7.9 -> 4.7.10, for GHSA-8r5x-fm3f-whwj (critical, AST type confusion in compile, bypassing the CVE-2026-33937 fix) and GHSA-xw65-4hp5-5hc7 (medium, injection via unsafe inline embedding of precompiled templates). Because this package has no package.json of its own, its package-lock.json is a generated artifact keyed by npmDepsHash in hashes.json, so that hash moves with the lockfile. version and sourceHash stay put: 0.14.3 is still the tarball being built. The declared range in the lockfile's root entry must stay at ^4.7.8, which 4.7.10 satisfies. `npm install handlebars@4.7.10 --package-lock-only` widens it to ^4.7.10 as a side effect, and that breaks the build -- default.nix pairs this lockfile with the tarball's own package.json, which says ^4.7.8, and npm ci refuses to run when the two disagree. The repository's open http-cache-semantics alert in .website (GHSA-ch52-4w7c-c8xp) is deliberately left alone. Version 4.3.0 looks like a fix because it sits outside the advisory's recorded range of <= 4.2.0, but diffing the two published tarballs shows maxAge(), satisfiesWithoutRevalidation() and the max-stale handling the advisory names are byte-identical between them; the only code change is a _varyMatches rewrite and a new status() accessor. The range stops at 4.2.0 because 4.3.0 postdates the advisory's last review, and github/advisory-database#10184 is open to extend it. Bumping would risk the alert closing against a version that still exhibits the behaviour, so it stays open for dismissal on its merits. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Expand the affected range t o <= 4.3.0. The published npm 4.3.0 tarball still reproduces the same security-zeroed Set-Cookie/max-stale bypass; this is a version-range correction, not a claim of a newly discovered vulnerability. No patched release is asserted.
Verified on 2026-10-06 with the published 4.3.0 package. Its index.js matches upstream revision b1d4bd682fbab0252985de45219f4e7497c0067c. In an isolated directory after installing http-cache-semantics@4.3.0, this deterministic reproduction uses only synthetic session data:
Observed: version 4.3.0, maxAge 0, satisfiesWithoutRevalidation true, setCookie session=synthetic-victim. The response is therefore reusable without origin validation despite the shared-cache cookie restriction. The source still zeroes this entry in maxAge() and then honors client max-stale in evaluateRequest(). Exploitation requires a consumer that retains such entries in a shared cache and passes incoming client directives into these methods. No live user sessions or deployed systems were tested.