Skip to content

common : throw instead of abort on grammar without llguidance - #29516

Merged
ggerganov merged 1 commit into
ggml-org:masterfrom
angt:common-throw-instead-of-abort-on-grammar-without-llguidance
Sep 27, 2026
Merged

common : throw instead of abort on grammar without llguidance#29516
ggerganov merged 1 commit into
ggml-org:masterfrom
angt:common-throw-instead-of-abort-on-grammar-without-llguidance

Conversation

@angt

@angt angt commented Sep 27, 2026

Copy link
Copy Markdown
Member

Overview

Not a good idea to abort, test with:

curl -X POST http://127.0.0.1:8080/completion \
    -H 'Content-Type: application/json' \
    -d '{"prompt":"hi","grammar":"%llguidance"}'

Additional information

Requirements

@angt
angt requested a review from a team as a code owner September 27, 2026 07:38
@angt
common : throw instead of abort on grammar without llguidance
95ddea0 
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
angt force-pushed the common-throw-instead-of-abort-on-grammar-without-llguidance branch from 2e689d4 to 95ddea0 Compare September 27, 2026 07:38
@angt angt changed the title common: throw instead of abort on grammar without llguidance common : throw instead of abort on grammar without llguidance Sep 27, 2026
@ggerganov ggerganov added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Sep 27, 2026
@ggerganov
ggerganov merged commit da6c28e into ggml-org:master Sep 27, 2026
13 checks passed
pierreguillot pushed a commit to Ircam-Partiels/llama.cpp that referenced this pull request Oct 1, 2026
@angt @pierreguillot
common : throw instead of abort on grammar without llguidance (ggml-o…
6be9d62 
…rg#29516)

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
@angt
common : throw instead of abort on grammar without llguidance (ggml-o…
3f39786 
…rg#29516)

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Oct 7, 2026
@angt edwardyoon
common : throw instead of abort on grammar without llguidance (ggml-o…
fc21353 
…rg#29516)

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
(cherry picked from commit da6c28e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angt @ggerganov