Repository navigation
Conversation
Member
|
Should we make it |
Contributor
@SuajCarrot did the work in #222. I have tested that on Linux but not on Windows. |
I have successfully tested it on Windows. |
Member
|
Ok, let's go with #222 then |
thedanhoffman
pushed a commit
to thedanhoffman/llama.cpp
that referenced
this pull request
Aug 15, 2026
update to ov-2026.3, update device drivers
ckti
pushed a commit
to ckti/llama.cpp-consolidated
that referenced
this pull request
Aug 22, 2026
The roll-up took upstream's tests/test-chat.cpp but kept the fork's older
common_chat_params_init_deepseek_v3_2, so four upstream behaviours were
missing and test-chat aborted:
- response_format is not passed to the template as additional_context
- TC_SEPARATOR ("\n\n") is not accepted before a tool-call block
- the enable_thinking==false continuation path emitted <think></think>
instead of </think>
- content_before_tools did not tolerate the separator or trailing space
Restores all four from upstream. The fork's own tolerance for optional
whitespace before <think> is preserved.
test-chat now passes; ctest is 58/59 with the only failure being the
pre-existing TQ3_1S/TQ4_1S large-N sentinel issue tracked in ggml-org#285.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the
quantize.shscript so that it can run properly on different platforms (including the Windows platform in the WSL environment).