Repository navigation
CUDA: Add conv3d. - #24569
Closed
Sero1000 wants to merge 2 commits into
Closed
CUDA: Add conv3d.#24569Sero1000 wants to merge 2 commits into
Sero1000 wants to merge 2 commits into
Conversation
github-actions
Bot
added
Nvidia GPU
Collaborator
|
see #16948 |
Author
|
I see, noticed the PR wasn't merged and the last update on it was about 6 months ago. Is there something specific in that PR that caused it not to get merged ? |
Contributor
|
Sorry for only getting around to this PR now, the reason the convolution PRs are stuck in limbo is because there isn't enough maintainer attention around it. I'm a general CUDA maintainer but I'm not familiar with how to e.g. correctly benchmark convolution kernels against each other. And it's not clear to me who I should delegate management of it to either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added Conv_3D operator implementation for CUDA. Part of #14909. Not the most performant implementation, but I'm planning on working to improve performance.
Additional information
Tested the implementation with
test-backend-ops -o CONV_3D. All tests are passing.Requirements