Skip to content

ggml: remove ggml-ext.h - #21869

Merged
ggerganov merged 2 commits into
ggml-org:masterfrom
ngxson:xsn/ggml_ext_h_move
Apr 14, 2026
Merged

ggerganov merged 2 commits into
ggml-org:masterfrom
ngxson:xsn/ggml_ext_h_move

Conversation

@ngxson

@ngxson ngxson commented Apr 13, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Fix #21867 Fix #21860

Not quite sure if the ggml-ext.h is intended to be a public header, but I believe it should be (so that the symbols can be exposed in the dynamic library)

Requirements

@ngxson
ngxson requested a review from JohannesGaessler April 13, 2026 20:59
@ngxson
ngxson requested review from CISC and ggerganov as code owners April 13, 2026 20:59
@github-actions github-actions Bot added the ggml changes relating to the ggml tensor library for machine learning label Apr 13, 2026
@ggerganov
ggerganov force-pushed the xsn/ggml_ext_h_move branch from 6b9523d to 1a900a0 Compare April 14, 2026 10:36
@ggerganov ggerganov changed the title ggml: correct placement of ggml-ext.h ggml: remove ggml-ext.h Apr 14, 2026

@ggerganov ggerganov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was ggml-ext.h to be a private header, but I now realize that this will not work. Removed the header and moved everything to the ggml-backend.h. cc @JohannesGaessler

@ggerganov ggerganov added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Apr 14, 2026

@JohannesGaessler JohannesGaessler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine with me.

@ggerganov
ggerganov merged commit fae3a28 into ggml-org:master Apr 14, 2026
46 of 47 checks passed
mengqin pushed a commit to mengqin/llama.cpp that referenced this pull request Apr 20, 2026
* ggml: correct placement of ggml-ext.h

* ggml : remove ggml-ext.h

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* ggml: correct placement of ggml-ext.h

* ggml : remove ggml-ext.h

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
* ggml: correct placement of ggml-ext.h

* ggml : remove ggml-ext.h

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
MrLordCat referenced this pull request in MrLordCat/llama.cpp-rdna-lab Jul 16, 2026
* ggml: correct placement of ggml-ext.h

* ggml : remove ggml-ext.h

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
* ggml: correct placement of ggml-ext.h

* ggml : remove ggml-ext.h

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
* ggml: correct placement of ggml-ext.h

* ggml : remove ggml-ext.h

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homebrew can't compile llama.cpp Compile bug: fatal error: '../src/ggml-ext.h' file not found

3 participants