Skip to content

chore: Set the default of attach_stacktrace to True - #7491

Merged
sentrivana merged 4 commits into
major/3.0from
ivana/major/change-attach-stacktrace
Sep 15, 2026
Merged

sentrivana merged 4 commits into
major/3.0from
ivana/major/change-attach-stacktrace

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

PY-2779

@sentrivana sentrivana changed the title chore: Flip attach_stacktrace=True chore: Set the default of attach_stacktrace to True Sep 14, 2026
@sentrivana
sentrivana marked this pull request as ready for review September 15, 2026 08:33
@sentrivana
sentrivana requested a review from a team as a code owner September 15, 2026 08:33
@sentrivana
sentrivana merged commit d68570b into major/3.0 Sep 15, 2026
141 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/major/change-attach-stacktrace branch September 15, 2026 08:49
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

64210 passed | ❌ 3 failed | ⏭️ 3291 skipped | Total: 67504 | Pass Rate: 95.12% | Execution Time: 206m 6s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -67948
Passed Tests 📉 -64111
Failed Tests 📈 +3
Skipped Tests 📉 -3840

➕ New Tests (3)

View new tests
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.11-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:276: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:276: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:276: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:276: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v6.1
Error: tests/integrations/django/test_cache_module.py:276: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:276: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2268 uncovered lines.
❌ Project coverage is 89.46%. Comparing base (660a4b3) to head (791847c).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.18%    89.46%    -0.72%
==========================================
  Files          193       180       -13
  Lines        25768     21513     -4255
  Branches      9532      7814     -1718
==========================================
+ Hits         23236     19245     -3991
- Misses        2532      2268      -264
- Partials      1432      1227      -205

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants