fix(starlette,fastapi)!: Stop eagerly consuming request bodies - #7487
Merged
alexander-alderman-webb merged 5 commits intoSep 14, 2026
Merged
Conversation
alexander-alderman-webb
marked this pull request as draft
September 14, 2026 07:12
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 830db2f. Configure here.
Contributor
Codecov Results 📊✅ 66169 passed | ⏭️ 3292 skipped | Total: 69461 | Pass Rate: 95.26% | Execution Time: 207m 34s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2261 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.17% 89.49% -0.68%
==========================================
Files 193 180 -13
Lines 25768 21514 -4254
Branches 9532 7814 -1718
==========================================
+ Hits 23236 19253 -3983
- Misses 2532 2261 -271
- Partials 1432 1223 -209Generated by Codecov Action |
alexander-alderman-webb
marked this pull request as ready for review
September 14, 2026 07:54
sentrivana
approved these changes
Sep 14, 2026
alexander-alderman-webb
deleted the
webb/starlette/eager-request-body
branch
September 14, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Read the request body in the event processor body and only rely on cached attributes.
The code to read the request body in
StarletteRequestExtractor.extract_request_info()now mirrors_get_cached_request_body_attribute(), which is used to get the request for streamed spans.Issues
Closes #7285
Closes #4827
Closes #4764
Reminders
uv run ruff.feat:,fix:,ref:,meta:)