chore: Adapt even more tests - #7462
Merged
Merged
Conversation
Contributor
Codecov Results 📊✅ 68079 passed | ⏭️ 3315 skipped | Total: 71394 | Pass Rate: 95.36% | Execution Time: 211m 23s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2329 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.21% 89.58% -0.63%
==========================================
Files 193 181 -12
Lines 25790 22342 -3448
Branches 9532 8120 -1412
==========================================
+ Hits 23265 20013 -3252
- Misses 2525 2329 -196
- Partials 1432 1331 -101Generated by Codecov Action |
sentrivana
commented
Sep 11, 2026
|
|
||
| def __repr__(self) -> str: | ||
| return f"<{self.__class__.__name__}(sampled={self.sampled})>" | ||
| return f"<{self.__class__.__name__}(name={self.name}, sampled={self.sampled})>" |
Contributor
Author
There was a problem hiding this comment.
Now that no-op spans optionally accept a name, adding it to __repr__ makes debugging easier.
sentrivana
marked this pull request as ready for review
September 11, 2026 08:23
alexander-alderman-webb
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove tests testing implementation details of the old tracing system. Adapt tests that still make sense in span streaming. Remove tests that already have a streaming version.