chore: Remove unnecessary None checks - #7449
Merged
Merged
Conversation
sentrivana
commented
Sep 9, 2026
Contributor
Codecov Results 📊✅ 70798 passed | ⏭️ 3370 skipped | Total: 74168 | Pass Rate: 95.46% | Execution Time: 220m 55s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 93.33%. Project has 2268 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.20% 90.00% -0.2%
==========================================
Files 193 185 -8
Lines 25788 22678 -3110
Branches 9530 8224 -1306
==========================================
+ Hits 23261 20410 -2851
- Misses 2527 2268 -259
- Partials 1432 1316 -116Generated by Codecov Action |
None checks
sentrivana
marked this pull request as ready for review
September 9, 2026 15:20
alexander-alderman-webb
approved these changes
Sep 9, 2026
Contributor
|
I've removed unnecessary checks in the other GenAI integrations as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these should be lists, never
None.