Skip to content

chore(dramatiq): Remove transaction-based tracing - #7445

Merged
sentrivana merged 2 commits into
major/3.0from
ivana/major/remove-transactions-dramatiq
Sep 9, 2026
Merged

chore(dramatiq): Remove transaction-based tracing#7445
sentrivana merged 2 commits into
major/3.0from
ivana/major/remove-transactions-dramatiq

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

PY-2690

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

71427 passed | ⏭️ 3370 skipped | Total: 74797 | Pass Rate: 95.49% | Execution Time: 218m 9s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -64239
Passed Tests 📉 -60478
Failed Tests
Skipped Tests 📉 -3761

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2286 uncovered lines.
❌ Project coverage is 89.99%. Comparing base (d0cd363) to head (a2dbfda).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/dramatiq.py 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    89.99%    -0.21%
==========================================
  Files          193       185        -8
  Lines        25788     22831     -2957
  Branches      9530      8328     -1202
==========================================
+ Hits         23261     20545     -2716
- Misses        2527      2286      -241
- Partials      1432      1336       -96

Generated by Codecov Action

SPANDATA.MESSAGING_DESTINATION_NAME, message.queue_name
)
message._sentry_span_ctx = transaction
scope.set_transaction_name(message.actor_name, source=SegmentNameSource.TASK)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new ^, wasn't there in the old streaming branch

@sentrivana
sentrivana marked this pull request as ready for review September 9, 2026 14:00
@sentrivana
sentrivana requested a review from a team as a code owner September 9, 2026 14:00
@sentrivana
sentrivana merged commit 70988ac into major/3.0 Sep 9, 2026
149 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-transactions-dramatiq branch September 9, 2026 14:09

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a2dbfda. Configure here.

},
SPANSTATUS.OK,
True,
True,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused capture_events fixture parameter left in test

Low Severity

The capture_events fixture parameter was left in the test_task_transaction function signature after removing the transaction-based code path. The function now only uses capture_items but capture_events is still requested as a fixture without ever being called. Every other occurrence of capture_events in this file actually invokes it (e.g., events = capture_events()). This is a leftover from the refactoring that adds unnecessary noise to the test signature.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a2dbfda. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants