Skip to content

fix(clickhouse_driver): Only set db.result in breadcrumb with sensitive data opt-in - #7432

Open
alexander-alderman-webb wants to merge 3 commits into
masterfrom
webb/clickhouse-driver/respect-pii
Open

fix(clickhouse_driver): Only set db.result in breadcrumb with sensitive data opt-in#7432
alexander-alderman-webb wants to merge 3 commits into
masterfrom
webb/clickhouse-driver/respect-pii

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Fix an oversight from 9d2b826

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb changed the title fix(clickhouse_driver): Only set db.result in breadcrumb with sensitive data opt-in fix(clickhouse_driver): Only set db.result in breadcrumb with sensitive data opt-in Sep 8, 2026
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 8, 2026 14:19
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 8, 2026 14:19
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

130694 passed | ⏭️ 7131 skipped | Total: 137825 | Pass Rate: 94.83% | Execution Time: 467m 17s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +119
Passed Tests 📈 +110
Failed Tests
Skipped Tests 📈 +9

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2521 uncovered lines.
✅ Project coverage is 90.22%. Comparing base (f4d4af7) to head (0df34ad).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.22%    90.22%        —%
==========================================
  Files          193       193         —
  Lines        25772     25772         —
  Branches      9514      9514         —
==========================================
+ Hits         23251     23251         —
- Misses        2521      2521         —
- Partials      1435      1435         —

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants