Skip formatting log records when Sentry logs are off - #7422
Merged
Conversation
SentryLogsHandler.emit called format() before the capture check, so every record paid for a Formatter even with the feature off.
sentrivana
reviewed
Sep 8, 2026
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
Thanks @gyanu2507, the change looks good to me, please have a look at the suggestion I left.
|
|
||
|
|
||
| def test_sentry_logs_handler_skips_format_when_disabled(sentry_init): | ||
| sentry_init() |
Contributor
There was a problem hiding this comment.
Better to be explicit here to not have this break if the default changes:
Suggested change
| sentry_init() | |
| sentry_init(integrations=[LoggingIntegration(capture_sentry_logs=False)]) |
Contributor
Author
There was a problem hiding this comment.
Done. The test now passes LoggingIntegration(capture_sentry_logs=False) so it still holds if the default flips.
The default is off today. Pinning it keeps the test honest if that changes.
sentrivana
enabled auto-merge (squash)
September 9, 2026 07:28
sentrivana
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SentryLogsHandler.emitcalledformat()before checking whether logs are enabled. Every stdlib record paid for a Formatter even with the feature off.Format after the capture check.
Fixes #7402