Repository navigation
Conversation
Contributor
size-limit report 📦
|
This was referenced Oct 5, 2026
betegon
marked this pull request as ready for review
October 8, 2026 10:49
betegon
force-pushed
the
bt/mcp-conventions-imports
branch
from
October 8, 2026 10:49
e6adecb to
6459be3
Compare
JPeer264
approved these changes
Oct 8, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for splitting this into its own PR. Btw is there a follow up planned for the ones which are not used by the conventions, such as MCP_TOOL_RESULT_PREFIX?
Member
Author
|
i thought we couldn't do anything with prefixes / indexes. great call out, here it is: getsentry/sentry-conventions#689 |
betegon
force-pushed
the
bt/mcp-conventions-imports
branch
from
October 13, 2026 08:51
901e5c8 to
a6f65bf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
@sentry/conventions/attributesfor registered MCP keys, including all singleton and indexed result fields. The branch now uses published conventions0.27.0fromdevelop, so both local result prefixes can be removed.Before, the SDK constructed
mcp.tool.result.0.contentfrom a local prefix. After,MCP_TOOL_RESULT_KEY_CONTENT.replace('<key>', '0')produces that same key. Singleton keys, values, original array indexes, and input/output capture behavior remain unchanged. Deprecated tool-result fields stay emitted for compatibility; this change adds no aliases or backfill.This is the mechanical base for network metadata (#24506), OAuth attribution (#24508), and canonical OpenTelemetry attributes (#25060). The latter separately adds complete serialized results in
gen_ai.tool.call.result.