Repository navigation
Conversation
The user agent parser reports mobile browsers as separate families such as Mobile Safari, Chrome Mobile or Firefox iOS. The legacy browser filter compared the family against the desktop name only, so an iOS Safari 15 event passed the Safari filter. Map the mobile families to their desktop counterpart before comparing versions, as was already done for IE Mobile.
Replace the family remap with explicit chrome_mobile, safari_mobile, firefox_mobile, edge_mobile and opera_mobile options. The desktop options keep their behavior, so projects opt into filtering mobile browsers on their own.
shellmayr
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile Safari,Mobile Safari UI/WKWebView,Chrome Mobile,Chrome Mobile iOS,Chrome Mobile WebView,Firefox Mobile,Firefox iOS,Edge MobileandOpera Mobile. The existing options compare against the desktop family only, so an iOS Safari 15 event passed thesafarifilter, which Sentry describes as "Safari Version 15 and lower".chrome_mobile,safari_mobile,firefox_mobile,edge_mobileandopera_mobileoptions. Desktop options keep their behavior, so projects opt into mobile filtering on their own.opera_mobilefilters version 73 and lower, the release that matches Chrome 110 in time.