Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize
event.flamegraphattachments and preserve their type and payload through ingestion, including Kafka and objectstore storage. Like view hierarchies, these attachments require an event ID but do not create an event themselves. Discard outcomes identify them asattachment:flamegraph.This is transport support for the draft contract in getsentry/sentry-docs#19774. Symbolication is handled separately in Sentry. This change does not add structured scrubbing or multipart filename inference.
Verification
make check,make build, two focused Rust tests, and three attachment integration cases passed. Local Relay-to-Sentry ingestion also confirmed the attachment type and unchanged payload.