Repository navigation
feat: parse <empty> proxy on Linux - #119
Merged
Merged
Conversation
7 tasks done
supervacuus
approved these changes
Feb 7, 2025
jpnurmi
pushed a commit
that referenced
this pull request
Oct 19, 2026
…macOS (#175) sentry-native passes `<empty>` when the proxy is explicitly set to an empty string. The libcurl transport already maps it to no proxy (#119). The WinHTTP transport fell back to WINHTTP_ACCESS_TYPE_AUTOMATIC_PROXY, and the macOS transport passed `<empty>/` to CrackURL and std::stoi. Open the WinHTTP session with WINHTTP_ACCESS_TYPE_NO_PROXY, and give the macOS session an empty connectionProxyDictionary, which disables the proxy. Co-authored-by: Oren Jacobian Pana <orenjp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of getsentry/sentry-native#1111
Related to this change in
sentry_backend_crashpad