Warden: code-review

[github-actions]

Warden Scheduled Scan Results

Run: 2026-08-17T08:08:43.330Z
Commit: e6ef59b

Summary

Severity	Count
High	1
Medium	7
Low	1

Findings

src/benchmarks/claude-ui/transcript.ts

• PDP-Q2S commandPrefixOffsets infinite loops on empty prefix (L239-L243) · high
  When prefix is an empty string, command.indexOf('', start) returns start and start never advances, causing an infinite loop. Guard against empty prefixes before entering the loop.

src/benchmarks/claude-ui/first-run-preflight.ts

• CTH-4R3 terminatePreflightApp can mask original error when appendFile throws (L43-L62) · medium
  When suppressFailure is true but appendLifecycleLog fails, the resulting file-system error replaces the actual failure being suppressed, making debugging difficult.

src/benchmarks/claude-ui/harness.ts

• XAD-YZL Truthiness check before strict boolean check can create orphaned directory (L638-L642) · medium
  The mkdir for claudeWorkingDirectory uses a truthiness check, but the skillDirs validation below requires isolatedWorkingDirectory === true. A truthy non-boolean config value (e.g., from JSON) would create a tmpdir and then throw, leaving an orphaned directory.

src/benchmarks/claude-ui/run-directory.ts

• DAP-8WT suitePaths may throw instead of returning [] when path is a file or unreadable (L16-L20) · medium
  directoryExists only checks path existence with access, so passing a file path or an unreadable directory causes readdir to throw an unhandled exception. Use try/catch around readdir like harness.ts:listYamlFiles does.

src/benchmarks/claude-ui/simulator-deletion.ts

• G26-HMV Missing test for createdByHarness deletion guard (L25-L27) · medium
  No test covers the createdByHarness !== true throw path, leaving the safety guard against deleting non-harness simulators untested.

src/benchmarks/claude-ui/simulator-lifecycle.ts

• 4MZ-CR8 JSON.parse on external command output can throw unhandled SyntaxError (L152) · medium
  Wrap JSON.parse with a try/catch to provide a meaningful error when simctl output is not valid JSON.

src/cli/cli-tool-catalog.ts

• TN2-LHR Remote tool errors silently ignored when content array is empty (L65-L71) · medium
  If a remote Xcode IDE tool returns isError: true with no text content items, the proxy handler resolves successfully without emitting any error status.

src/cli/commands/daemon.ts

• 9M2-SUE Foreground daemon start lacks error handling (L153-L165) · medium
  The foreground branch in handleStart does not wrap startDaemonForeground in try/catch, unlike the background branch. If startDaemonForeground throws (e.g., executable not found or permission error), the rejection propagates unhandled instead of being logged with a clean error message.

src/cli/daemon-client.ts

• HRZ-JLV Unvalidated daemon response fields cause TypeError on malformed error frames (L97-L100) · low
  Accessing res.error.message.startsWith() without validating the error object shape causes the client promise to reject with a confusing TypeError when the daemon sends a malformed response missing the message field. The throw is caught by createFrameReader’s try-catch and forwarded to onError, but instead of a graceful protocol validation error, the caller receives a raw TypeError: Cannot read properties of undefined (reading 'startsWith').

---

Generated by Warden