Repository navigation
Conversation
time-attack
pushed a commit
to time-attack/gstack
that referenced
this pull request
Jul 14, 2026
An interrupted upgrade leaves the previous .bak directory in place; the next run's 'mv X X.bak' then moves the install INSIDE the stale backup (X.bak/gstack), nesting one level deeper on every retry — the recursive .bak trees reported in garrytan#922. rm -rf the stale backup before each mv at both backup sites (vendored Step 4 and local-copy Step 4.5). Root-cause replacement for PR garrytan#922 (reported the problem; its cleanup globs matched '.bak*' basenames the flow never creates). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Thanks for this, @aylint. The fix is now on main: /gstack-upgrade refuses to run over a stale .bak and swaps directories with mv instead of nesting copies (gstack-upgrade/SKILL.md.tmpl) (fixed in v1.91.16.0, #3014). Closing as superseded; if you still see the problem on the latest gstack, please open an issue with ./setup --status output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
/gstack-upgradebug that could create recursive backup trees during repeated upgrades.The issue had two paths:
.bak*.bak*directories around becausegit reset --harddoes not remove untracked backup dirsWhat Changed
.bak*aftergit reset --hardcp -Rfwithrsync, excluding.gitand.bak*.bak*after vendored syncValidation
Ran:
bun run gen:skill-docsbun run skill:checkbun testbun test test/gen-skill-docs.test.tsNotes:
origin/mainand are not caused by this PR:bun run skill:checkfails because multi-host generated skill trees are stale upstreamtest/host-config.test.tshas stale/missing golden-host outputs upstreamtest/team-mode.test.tstimes out upstreambrowse/test/commands.test.tsandbrowse/test/snapshot.test.tsfail withEADDRINUSEupstream in this environmentUser Impact
/gstack-upgradeno longer copies backup trees into vendored installs. Git-based upgrades now clear stale top-level.bak*directories, and vendored sync excludes.bak*to prevent backups from recursing during repeated upgrades.