Repository navigation
fix(browse): honor proxy env vars in Playwright launches - #916
Closed
ningfeemic-dev wants to merge 1 commit into
Closed
ningfeemic-dev wants to merge 1 commit into
ningfeemic-dev wants to merge 1 commit into
Conversation
Contributor
|
Thanks for this, @ningfeemic-dev. Since April, browse has explicit proxy support: |
capy-ai Bot
pushed a commit
that referenced
this pull request
Oct 11, 2026
…s, no NUL bunfig (Wave 9 Lane E) (#3135) browse resolves its proxy from --proxy, BROWSE_PROXY_URL, then HTTPS_PROXY, HTTP_PROXY and ALL_PROXY (BROWSE_PROXY_URL=direct opts out), translates NO_PROXY to Chromium bypass rules with loopback always kept, and hashes the proxy and NO_PROXY rules into the daemon config so a differing environment is refused with the variable named. Unparseable standard variables warn and go direct; browse stop always stops (#915, supersedes #916). Safe directories and targets resolve through one realpath (fs.realpathSync.native), fixing Windows 8.3 temp paths (#3104). Bun children get an empty private bunfig instead of --config=NUL, which panicked Bun 1.3.10 on Windows (#3085). Co-authored-by: ningfeemic-dev <239259264+ningfeemic-dev@users.noreply.github.com>
Contributor
|
Superseded by #3135, merged in v1.91.86.0 (47cd4a9), which builds on this PR's approach. It adds NO_PROXY bypass rules, an explicit opt-out, and a check that refuses a daemon whose proxy settings don't match. You're credited as co-author on the merged commit. Thanks @ningfeemic-dev. |
levi85
pushed a commit
to levi85/gstack
that referenced
this pull request
Oct 14, 2026
…s, no NUL bunfig (Wave 9 Lane E) (garrytan#3135) browse resolves its proxy from --proxy, BROWSE_PROXY_URL, then HTTPS_PROXY, HTTP_PROXY and ALL_PROXY (BROWSE_PROXY_URL=direct opts out), translates NO_PROXY to Chromium bypass rules with loopback always kept, and hashes the proxy and NO_PROXY rules into the daemon config so a differing environment is refused with the variable named. Unparseable standard variables warn and go direct; browse stop always stops (garrytan#915, supersedes garrytan#916). Safe directories and targets resolve through one realpath (fs.realpathSync.native), fixing Windows 8.3 temp paths (garrytan#3104). Bun children get an empty private bunfig instead of --config=NUL, which panicked Bun 1.3.10 on Windows (garrytan#3085). Co-authored-by: ningfeemic-dev <239259264+ningfeemic-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
gstack browseso Chromium navigation honors standard proxy environment variables.Closes #915
What changed
getProxySettings()inbrowse/src/browser-manager.tsHTTPS_PROXY/https_proxyHTTP_PROXY/http_proxyALL_PROXY/all_proxyNO_PROXY/no_proxyproxyinto all Chromium launch paths:chromium.launch(...)chromium.launchPersistentContext(...)launchPersistentContext(...)Validation
Before fix, proxied environments could still fail with:
After patch + rebuild locally: