Repository navigation
v1.91.118.0 test: held-install recovery fixture no longer assumes the checkout has no local main - #3237
Merged
Conversation
…s no local main actions/checkout leaves push runs on a local main branch, so the fixture's clone already had main and 'checkout --orphan main' failed. Build the root commit on an orphan held-fixture branch and push HEAD:refs/heads/main; add a regression covering a source on main and a detached source with no branch. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
Contributor
E2E Evals: ✅ PASS0 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $0 rule/judge cost | reconcile exit: 0 Profile: pr / mode Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. |
… checkout has no local main Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free Tests has been red on every push to main since 3e8b34d (#3209): all five
makeFixturecallers intest/held-install-recovery.test.tsfail atgit checkout -q --orphan main.Cause. On a push,
actions/checkoutrunsgit checkout --force -B main refs/remotes/origin/main, so the checkout has a localmainbranch. The fixture'sgit clone --shared ROOT worktherefore also has a localmain, andgit checkout --orphan mainrefuses withfatal: a branch named 'main' already exists(the CI log drops git's stderr; it reproduces on the runner's git 2.55.0 and on any local checkout ofmain).init.defaultBranchis not involved:git -c init.defaultBranch=main initfollowed bycheckout --orphan mainsucceeds.Why PR CI missed it. PR runs check out
refs/remotes/pull/N/mergedetached, with no local branch, so the clone has nomainand the orphan checkout succeeds. Selection was not the gap: #3209's PR run (38965221645) ran this file in shard 17 and it passed.Fix. The fixture builds its root commit on an orphan branch named
held-fixtureand pushesHEAD:refs/heads/mainto the bare origin, so it no longer depends on which branch the source checkout is on. Every assertion is unchanged.Regression.
makeFixturetakes an optional source, and a new test builds the fixture from a clone checked out onmain(the push-run form) and from one detached with no branches (the PR-run form), asserting originmainis the fixed release whose only parent is the held root commit. Without the fix theon maincase fails with the same error and the detached case passes, which is exactly the push/PR split.