Repository navigation
fix(auq-format): clarify label vs description split to prevent InputValidationError - #3222
Bhumika-1432006 wants to merge 1 commit into
Conversation
…alidationError (garrytan#3219) The decision-brief format described option text as a single conceptual block, causing the model to write long ✅/❌ prose as the label field and omit the short chip label entirely. This produces InputValidationError round trips. Add an explicit 'label vs description' note after the format template explaining that: - label: short phrase (≤5 words), chip text, (recommended) goes here - description: the ✅/❌ prose and add a self-check bullet for plan-review skills to verify both fields are present before emitting the tool call. Regenerate all SKILL.md files from updated template.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Triage (fix wave 5, GSTA-37): the problem (#3219 item 2) is real, but it's S3: the InputValidationError round trip corrects itself. This PR edits the shared preamble resolver, which regenerates every SKILL.md, including outputs owned by open PRs (#3190, #3209), and it needs a full paid eval pass over every skill. It's deferred to the next batched wave and will be rebased onto main then. The other half of #3219 (the report rewrite) is fixed in #3225. |
|
Thanks @Bhumika-1432006 for tracking this down and for the clear write-up. We're going to close this one, and here's why. We tried the smallest version of it on current main: just your checklist bullet, which only renders into the four plan-review skills. Even that one line pushes plan-ceo-review, plan-eng-review and plan-devex-review over the size caps in If we do a trim pass on the plan-review preambles, we'll fold a one-line label/description note in then and credit this PR. Thank you for the contribution. |
Partially addresses #3219 (the AUQ option label issue; the report-rewrite issue is tracked separately).
Problem
In a 7-pass plan review, the model repeatedly wrote the long ✅/❌ description prose into the
labelfield and omitted the short chip label entirely, producingInputValidationErrorround trips. The format template described option text as a single conceptual block without distinguishing the two required tool fields.Fix
After the decision-brief format template in
scripts/resolvers/preamble/generate-ask-user-format.ts, add an explicit AskUserQuestion tool fields — label vs description note:label: short phrase (≤5 words), chip text;(recommended)goes heredescription: the ✅/❌ reasoning proseAlso add a self-check bullet for plan-review skills:
Files changed
scripts/resolvers/preamble/generate-ask-user-format.ts— source of truthSKILL.mdfiles — regenerated withbun run gen:skill-docs --host claude