Repository navigation
v1.91.22.0 feat(cso): reviewed, attested scanner build inputs + fixes so scanner qualification can pass - #3035
Merged
Merged
Conversation
…er qualification fixes
|
😎 This pull request was merged. |
Contributor
E2E Evals: ✅ PASS0 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $0 rule/judge cost | reconcile exit: 0 Profile: pr / pr; selected behaviors: 0, judges: 0. Deferred to scheduled/release coverage: 3 behaviors and 0 changed prompt files. Deferred checks did not run and receive no PR-pass credit. Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. |
BenjaminDSmithy
added a commit
to BenjaminDSmithy/gstack
that referenced
this pull request
Oct 5, 2026
Upstream main moved to f97aefe (v1.91.22.0). Only the release files conflicted: VERSION, package.json, the agents digest and CHANGELOG.md. Resolved by taking main's side of each and re-versioning this PR from 1.91.21.0 to 1.91.25.0: bin/gstack-next-version against garrytan/gstack main reported 1.91.23.0 claimed by garrytan#3036 and 1.91.24.0 by garrytan#3031. bin/gstack-version-bump wrote VERSION, package.json (1.91.25) and the digest; the PR's CHANGELOG entry sits above main's 1.91.22.0 entry, renamed to 1.91.25.0, with nothing of main's entries changed. Checked on the merged tree: the gate reports 158 checked, exit 0; the agents-digest, ship-version-sync, version-source, skill-validation, context-budget, catalog-budget and team-mode tests pass, 415 pass, 0 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
levi85
pushed a commit
to levi85/gstack
that referenced
this pull request
Oct 14, 2026
… so scanner qualification can pass (garrytan#3035) * v1.91.22.0 feat(cso): reviewed, attested scanner build inputs + scanner qualification fixes * Regenerate agents digest for v1.91.22.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cso's contained scanner execution was unavailable becauselib/cso/scanner-images/build-inputs.jsonwas an emptypendingplaceholder andcso-scanner-images.ymlhad never run. This PR commits reviewed, attested inputs for all six scanners on both native platforms, and fixes the gstack defects the first qualification run would have hit.Reviewed scanner inputs
build-inputs.jsonnow pins, for gitleaks 8.30.1, OSV-Scanner 2.6.0, Semgrep 1.179.0, zizmor 1.30.1, Trivy 0.75.0 and Schemathesis 4.29.1 on linux/amd64 and linux/arm64, plus the BuildKit SBOM generator:None of the upstream images publish GitHub artifact attestations, so the bases come from
garrytan/gstack-cso-scanner-basesreleasebases-2026.10.04.3. That repo re-publishes each pinned upstream digest (checked for tag drift, platform membership and revision label; Trivy's cosign signature is verified too) and adds the offline assets:opengrep-rulesfork, because Semgrep's registry rules forbid redistribution.The repo's workflow signs provenance and the SBOM.
Before the state changed to
reviewed, Garry double-checked an independent re-verification run from outside CI:gh attestation verifyflags, for both predicates, plus a negative control.scripts/cso-attestation-evidence.ts, all equal.hash-asset, all equal.Fixes the first
cso-scanner-images.ymlrun neededntap-20210312-0006) read as phone numbers and four-part versions as IP addresses, which maderunProcesswithhold both channels. Scanner captures now opt intoredaction: 'splice': each located span becomes a<REDACTED-…>marker, and the result is released only when every view (each channel, both concatenation orders and the chronological interleaving) re-scans clean. A span split across stdout and stderr, or one that can't be located, still withholds everything.--max-timeis spent, and the adapter passed the full deadline, so CSO always killed it. The budget is now 75% of the deadline, andstop_reason: max_timecounts as complete only when every selected operation ran.test/cso-scanner-docker-integration.test.tsfixture.snapshot/, which is what the executor mounts. Every scanner previously hit ENOENT.lodash@4.17.20. Before, OSV exited 128 on an empty lockfile, and neither OSV nor Trivy exercised its database.test/cso-scanner-release.test.tsaccepts either the empty placeholder or a complete reviewed matrix, whichscannerBuildMatrixvalidates.Validation
bun run typecheckandbun run format:cso:checkpass.test/cso-*.test.tsfiles pass locally on Bun 1.4.0, with new tests for splice redaction and Schemathesis completion.bun run test:ubicloud) passes: 9/9 shards.GSTACK_CSO_DOCKER_TESTS=1.After merge
Dispatch
cso-scanner-images.ymlonmainwithpromote_catalog=true, which needs approval of thecso-scanner-releaseenvironment. The first run may stop at the public-package check until the newcso-scanners/*GHCR packages are public. Until the resulting catalog PR merges, scans still reportnot assessed.