Repository navigation
spec(port): port the psk external injection guard (Refs #8883) - #9946
Closed
dmitrii-f-t27 wants to merge 2 commits into
Closed
dmitrii-f-t27 wants to merge 2 commits into
dmitrii-f-t27 wants to merge 2 commits into
Conversation
The twenty-second CR-CHAT-03 ring target (W3, L-CHAT-3-psk, RFC 9420 5.3/12.4.4): the PSK reference rules, in the original's fixed order - the canonical nonce length (thirty-two), the External identifier provisioned out of band, the Resumption group equal to the local one, the Resumption epoch strictly earlier than the current one (forward references are state-rollback primitives), and the (identifier, group, epoch, nonce) quad fresh against the replay ledger - as the D5 verdict (all five original variants carry no payload, so the code is the whole verdict), the original's rule order, and all ten PSK tests transcribed plus helper and rule-order tests. The original's reference and view structs become flat parameters, the byte vectors arriving as plain slices. The provisioned-identifier set becomes a slice of records holding the identifier with its length, the consumed-quad ledger a slice of records holding the identifier, the group identifier (possibly empty - the external form carries none), the epoch and the canonical nonce - both original BTreeSet contains answered by scans. The empty group form lives as a local empty array in each test that carries it. Checks (conventions 0-14): t27b test 14 passed 0 failed; t27c test-report 14/14, 0 vacuous; gen-rust output compiles under rustc; coverage Untested 0; ASCII only; seal saved, all hashes MATCH;
Contributor
Author
|
All required checks green (validate, check-linked-issue, parse-ratchet, t27b-native-linux, t27b-native-macos); cli-tri / duplicate-bodies / t27b-native-ratchet are the known non-required reds. Steward READY. Twenty-second CR-CHAT-03 target (22/47 T-PORT) — requesting owner merge when convenient, Refs #8883. |
This was referenced Oct 17, 2026
Merged
Merged
Merged
This was referenced Oct 17, 2026
spec(policy): l2_generation -- gen/json/ is t27c gen-json's backend directory (Closes #10079)
#10082
Merged
Merged
Merged
Merged
Merged
# Conflicts: # docs/reports/t27b_expectations.json
Contributor
Author
|
Superseded by #10175: the remaining CR-CHAT targets now land as one port-wave batch per specs/policy/pr_budget.t27 (#10067/#10074), which asks for one PR per ring batch instead of one per file. The spec body, seal and ledger row in this PR are unchanged there; the batch also carries one self-consistent duplicate-body bless. Closing this one-file PR keeps the merge queue and the Actions queue small. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The twenty-second CR-CHAT-03 ring target (W3, tracker #8883, epic gHashTag/trios#1812): port of
crates/trios-chat/rings/CR-CHAT-03/src/psk_external_injection.rs(Wave-26 Lane A, L-CHAT-3-psk, RFC 9420 5.3/12.4.4).A smuggled Pre-Shared Key reference must never reach the key schedule. Rules, in the original's fixed order:
Carried as the D5 verdict — all five original error variants carry no payload, so the code is the whole verdict.
Adaptations (t27 conventions): reference/view structs → flat parameters, byte vectors as plain slices; the provisioned set → slice of records (identifier + length); the consumed-quad ledger → slice of records holding the identifier, the group identifier (possibly empty — the external form carries none), the epoch and the canonical nonce; both
BTreeSetcontains answered by scans; the empty group form lives as a local empty array in each test that carries it.All 10 original PSK tests transcribed with exact asserts (both the equal-epoch and the past-epoch rollbacks; the replay quad with the empty external group), plus 3 helper tests and a rule-order ladder with the consumed quad riding under every earlier rule — 14 total.
Checks (conventions 0-14):
t27b test14 passed 0 failed, 0 blockers;t27c test-report14/14, 0 vacuous; gen-rust output compiles under rustc (0'static str, 0Vec<const); coverage Untested 0; ASCII only; seal saved, all hashes MATCH; ledger row added todocs/reports/t27b_expectations.json.Refs #8883