Repository navigation
Conversation
…#7873) duplicate-bodies stays red on master after #7864 because of a second group, from d4f74f8 (#7491): assign, status and update_status in specs/port/trios/crates/trios-server/src/mcp_endpoints/tasks.t27 all return TaskReply{task_id: "task-123", status: "assigned"}. The stubs are older than #7491. Before it the bodies were below dupe_scan's length floor ("no function body long enough to compare"), and the Value -> TaskReply rename for the types ratchet made them measurable. `python3 tools/dupe_scan.py --bless` records `assign 3`. It also carries #7864's three LinkSection lines, so this PR is green on its own and those lines no-op once #7864 lands. The real fix, porting the three bodies from trios, is a port task of its own and lowers the ledger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
gHashTag
pushed a commit
that referenced
this pull request
Oct 8, 2026
duplicate-bodies stays red on master after #7864 because of `assign 3`; the same line as #7874, which no-ops once it lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
gHashTag
pushed a commit
that referenced
this pull request
Oct 8, 2026
The previous commit wrote an empty tools/duplicate_bodies_baseline.txt (a git show of a branch that was not fetched). This restores it: master's ledger plus the four lines of #7864 and #7874, nothing else (dupe_scan: ok). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
This was referenced Oct 8, 2026
Merged
Contributor
This was referenced Oct 8, 2026
Merged
Owner
Author
|
Closing as superseded: #7887 (76836e2) records the same Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Closes #7873python3 tools/dupe_scan.pyand--self-testpass locallyDescription
#7864 records the
LinkSectioncopies, butduplicate-bodiesstays red on master because of a second group from d4f74f8 (#7491). Inspecs/port/trios/crates/trios-server/src/mcp_endpoints/tasks.t27, the functionsassign,statusandupdate_statusall returnTaskReply{task_id: "task-123", status: "assigned"}.These stubs are older than #7491. At d4f74f8^,
dupe_scan --likeon the file reported "no function body long enough to compare". TheValue→TaskReplyrename for the types ratchet made the bodies long enough to be measured, so this is not a new copy.Changes
tools/duplicate_bodies_baseline.txt:assign 3, written bypython3 tools/dupe_scan.py --bless.LinkSection_*lines. They are kept so this PR is green on its own, and they no-op once tools: ledger the three LinkSection constructor copies (Refs #7490) #7864 lands.Testing
Review Notes
Recording the group makes the gate green and changes no behaviour. It does not fix the port: three endpoints still return the same stub whatever they are asked. Porting the real bodies from
gHashTag/trios:crates/trios-server/src/mcp_endpoints/tasks.rsis a separate port task, and it lowers this ledger line when it lands.🤖 Generated with Claude Code
https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
Generated by Claude Code