feat(crm-duet): v2 -- braced tests over fns the host mirrors; two drifts found by binding - #4890
Merged
Merged
Conversation
…fts found by binding Binding v1 in 999-multibots-telegraf found its twelve tests braceless (inert), its SELLER/BUYER constants two real people's ids, and the host restating the turn limits, the retry and the discovery gate. v2: seven fns the host mirrors, twelve braced tests, roles instead of ids. Two drifts, settled on the spec's side: the host's negation window reached three words back (now NEGATION_WINDOW_WORDS), and the brief's soft paid cap has been two per run since the portrait came first (PAID_PER_RUN_SOFT = 2). state_after gains the 6-of-8 vector the old ones could not tell apart. 12/12, 0 vacuous, negative controls caught. Closes #4889 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k phi^2 + 1/phi^2 = 3 | TRINITY
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Sep 27, 2026
Owner
Author
|
Local gate. On this head, 7 checks are red. They are the same 7 that are red on master without this change, as noted in #4850 and #4852:
This PR touches one spec, its seal and a NOW entry. What holds locally:
Generated by Claude Code |
gHashTag
marked this pull request as ready for review
September 27, 2026 11:05
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4889
What changed
specs/automation/crm-duet.t27goes from v1 to v2.speaker_at,paid_tool_offered,claim_hit_counts,claim_is_honest,retry_allowed,state_after,business_bot_silent.SELLER/BUYERare roles (platform-owner,connected-seller) instead of two real people's Telegram ids.NEGATION_WINDOW_WORDS.PAID_PER_RUN_SOFTis now 2.state_after(6, 4, false) == "failed". The old vectors (3 of 8 and 8 of 8) passed under the mutationlines < turns.Evidence
t27c test-report: 12 tests, 12 pass.validate-vacuity: 0 vacuous.PAID_PER_RUN_SOFT = 3fails "the paid cap is soft and says so";lines < turnsfails "a run that broke off…".apps/vibee-editor/render/src/spec/crm-duet.test.ts: 13 host tests, 7 host mutations, all red.🤖 Generated with Claude Code
https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
Generated by Claude Code