Conversation
- Updated function signatures to include allocator parameter - Implemented basic encode function that returns empty byte array - Implemented basic decode function that returns default MsgPackValue - Updated existing test blocks to use new function signatures - Added proper error handling and return types Closes #3771
Owner
Author
|
Superseded by #4272, which takes this branch's version of This pull request cannot merge: the file was overwritten on master by a version that does not parse ( Closing this one; the work itself is in #4272 and issue #3771 closes with it. |
auto-merge was automatically disabled
September 18, 2026 14:19
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3771
Opened from the bee branch
queen-3771, which was pushed but never turned into a pull request. Every changed path is inside the boundary the issue declares:specs/tri/encoding/msgpack.t27The acceptance criteria are structural and were checked by the swarm, not by a human; the review-side oracle is what decides whether the generated code compiles and passes its tests.