Repository navigation
feat(bitnet): self-contained bundle — include trit_stdlib so it elaborates standalone - #1740
Merged
Merged
Conversation
The bundle emitted pipeline_stage2_compute (which instantiates trit27_dot_product) but omitted the trit stdlib that defines it, so it could not elaborate/synthesize standalone. Compose trit_stdlib.sv at dependency- first position; BUNDLE_ORDER/BUNDLE_FILE_COUNT 12 -> 13; update index-based unit tests. Simplify tests/bitnet_elaborate.rs to elaborate the bundle directory as-is -- now proves self-containment. Verified: iverilog -t null -s bitnet_engine_top over the bundle alone elaborates clean; unit 1500/0, bundle 21/21. No compiler change, no reseal. Closes #1739 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #1730.
gen-bitnet-bundleemittedpipeline_stage2_compute(which instantiatestrit27_dot_product) but did not include the trit stdlib that defines it — so the bundle could not elaborate or synthesize standalone (Unknown module type: trit27_dot_product).Closes #1739
Change
Compose
trit_stdlib.svinto the bundle at dependency-first position (index 0).BUNDLE_ORDER/BUNDLE_FILE_COUNT12 → 13; the index-based unit tests are updated accordingly.tests/bitnet_elaborate.rsis simplified to elaborate the bundle directory as-is (no separate stdlib emission) — so it now proves self-containment.Verification
iverilog -g2012 -t null -s bitnet_engine_topover the bundle directory alone elaborates clean (exit 0).bitnet_bundle21/21,bitnet_elaborate1/1; full suite green apart from the pre-existing, unrelatedbitnet_topreds (test: bitnet_top asserts stale contract (busy + mem tie-off) vs current gen-bitnet-engine-top #1726).🤖 Generated with Claude Code