Skip to content

fix(conformance): correct 5 stale gf16 vectors + wire oracle into CI (R7-loop #2) - #1673

Merged
gHashTag merged 2 commits into
masterfrom
fix/gf16-conformance-vectors
Aug 5, 2026
Merged

gHashTag merged 2 commits into
masterfrom
fix/gf16-conformance-vectors

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Problem (#1579)

conformance/gf16_ref.py exited non-zero on 5 named-constant vectors, and no CI ran it — so the drift went unnoticed.

Root cause (proven, not guessed)

Brute force over all 65536 GF16 codes shows the encoder picks the nearest code for each constant, decode is FPGA-consistent (32/32) and roundtrips (19/19). The vectors' expected.decoded values (e.g. 0.617919922 for phi_inverse) are not representable by any GF16 code — phantom/stale constants.

Fix

  • Set the 5 expected.decoded to the true mathematical constant, tolerance_abs to the format's quantization bound (only phase_transition needed widening, 0.0002 → 0.0005; its ULP error is 3.9e-4). Semantic is now "GF16 encoding of X lands within one ULP of X" — meaningful, not tautological.
  • Add .github/workflows/gf16-conformance.yml (stdlib-only) so the oracle runs on every change to it or its vectors.

Oracle: 35 pass / 0 fail (was 30/5), exit 0.

Not in scope: #1580 (gf_ref.py denormal Fraction blowup) is a separate architectural rewrite.

Closes #1579

🤖 Generated with Claude Code

conformance/gf16_ref.py exited non-zero on 5 named-constant vectors
(phi_inverse, consciousness_threshold, gravity_strength, quantum_spacing,
phase_transition). Proven by brute force over all 65536 codes: the encoder
picks the NEAREST GF16 code for each, and decode is FPGA-consistent +
roundtrips 19/19 -> the vectors' expected.decoded values were phantom (not
representable by any GF16 code). Set expected.decoded to the true constant
and tolerance_abs to the format's quantization bound (widened phase_transition
0.0002 -> 0.0005, whose ULP error is 3.9e-4). Oracle now 35 pass / 0 fail.

Added .github/workflows/gf16-conformance.yml so the oracle runs on every
change to it or its vectors (it was never in CI, which is how the drift went
unnoticed).

Closes #1579

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-05 09:23:55 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 2
PRs with All Checks Green 48
READY 0
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=d6b51a3bcc20 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Satisfies the required check-now-freshness gate (t27#141): every PR to master
must update docs/NOW.md. No code change.
@gHashTag
gHashTag enabled auto-merge August 5, 2026 12:51
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-05 12:52:01 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 3
PRs with All Checks Green 47
READY 0
FAILING 3
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=d6b51a3bcc20 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit 83093fb into master Aug 5, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gf16_ref.py fails 5 of its own conformance vectors, and no CI runs it

1 participant