Repository navigation
build(harness): retire low-value OpenCode carries - #1215
Conversation
fro-bot
left a comment
There was a problem hiding this comment.
Verdict: PASS
Data-only edit to packages/harness/harness.config.json: drops two integration refs — PR #7156 (default-variant carry) and PR #36179 (prompt-root OTEL span) — and retains 14 higher-value carries. The change is consistent with the package's Carry Policy (drop refs lacking a concrete ongoing need).
Verified:
- Resulting JSON is well-formed and parses;
integrationRefsarray has 14 entries, matching the PR description. - The trailing-comma cleanup on the retained
#36361entry is correct (no dangling comma, no syntax break). - No source or test hardcodes the removed PR numbers (
rg 7156|36179→ no matches) — nothing else references them. - The config is consumed generically by index/count (
integrate.tsmapssources/integrationRefs[i];cli.tsiterates), and no test asserts a fixed ref count against this file, so removing entries is safe. base_version(1.17.20) and all other keys are untouched.
Blocking issues
None
Non-blocking concerns
None
Missing tests
None. This is a curated data change to the carry allowlist, not new behavior. Existing generic-shape tests (integrate-command.test.ts, provenance.test.ts, cli.test.ts) already cover config parsing, element validation, and empty/non-empty carry sets. The carry set itself is validated at release time by the maintainer-reviewed LLM merge + per-platform build gate, not by unit tests.
Risk assessment (LOW):
Blast radius is confined to the next harness release's merge/build, which is maintainer-gated workflow_dispatch and fully commit-pinned/frozen after review — a bad carry set cannot reach a shipped binary without passing that gate. No runtime code path, public API, or action invocation consumes this file directly. Regression likelihood and security exposure are minimal; dropping refs only shrinks the patch surface.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/agent |
| Run ID | 29306995379 |
| Cache | hit |
| Session | ses_0a1075ca1ffeashvuVfl9o2uTq |
Summary
Verification
bun run --filter @fro.bot/harness testbun run --filter @fro.bot/harness buildbun run check-typesbun run lintbun run buildgit diff --check