Skip to content

build(harness): retire low-value OpenCode carries - #1215

Merged
marcusrbrown merged 1 commit into
mainfrom
chore/prune-opencode-carries-stage-1
Jul 14, 2026
Merged

marcusrbrown merged 1 commit into
mainfrom
chore/prune-opencode-carries-stage-1

Conversation

@marcusrbrown

Copy link
Copy Markdown
Collaborator

Summary

  • remove the default-variant carry while retaining subtask model/variant handling
  • remove the prompt-root OTEL span carry because shipped surfaces do not configure an OTLP exporter
  • retain 14 higher-value carries, including TUI stream batching and background-failure diagnostics

Verification

  • bun run --filter @fro.bot/harness test
  • bun run --filter @fro.bot/harness build
  • bun run check-types
  • bun run lint
  • bun run build
  • git diff --check

@fro-bot fro-bot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

Data-only edit to packages/harness/harness.config.json: drops two integration refs — PR #7156 (default-variant carry) and PR #36179 (prompt-root OTEL span) — and retains 14 higher-value carries. The change is consistent with the package's Carry Policy (drop refs lacking a concrete ongoing need).

Verified:

  • Resulting JSON is well-formed and parses; integrationRefs array has 14 entries, matching the PR description.
  • The trailing-comma cleanup on the retained #36361 entry is correct (no dangling comma, no syntax break).
  • No source or test hardcodes the removed PR numbers (rg 7156|36179 → no matches) — nothing else references them.
  • The config is consumed generically by index/count (integrate.ts maps sources/integrationRefs[i]; cli.ts iterates), and no test asserts a fixed ref count against this file, so removing entries is safe.
  • base_version (1.17.20) and all other keys are untouched.

Blocking issues

None

Non-blocking concerns

None

Missing tests

None. This is a curated data change to the carry allowlist, not new behavior. Existing generic-shape tests (integrate-command.test.ts, provenance.test.ts, cli.test.ts) already cover config parsing, element validation, and empty/non-empty carry sets. The carry set itself is validated at release time by the maintainer-reviewed LLM merge + per-platform build gate, not by unit tests.

Risk assessment (LOW):

Blast radius is confined to the next harness release's merge/build, which is maintainer-gated workflow_dispatch and fully commit-pinned/frozen after review — a bad carry set cannot reach a shipped binary without passing that gate. No runtime code path, public API, or action invocation consumes this file directly. Regression likelihood and security exposure are minimal; dropping refs only shrinks the patch surface.


Run Summary
Field Value
Event pull_request
Repository fro-bot/agent
Run ID 29306995379
Cache hit
Session ses_0a1075ca1ffeashvuVfl9o2uTq

@marcusrbrown
marcusrbrown merged commit bda1408 into main Jul 14, 2026
12 checks passed
@marcusrbrown
marcusrbrown deleted the chore/prune-opencode-carries-stage-1 branch July 14, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants