Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example walks directories through
self.iter(), which resolves each pathbefore recursing. Resolving follows symlinks, so a symlink pointing at one of
its own parents makes the walk descend the same tree over and over instead of
terminating.
Recurse through
self._iter()instead, which skips the resolve step. Theentries come from
iterdir()and are already known to exist, so resolvingthem again was redundant regardless.
Also drops the
path.joinpath(i), sinceiterdir()already yields fullpaths.
Fixes #234
Test plan
tox run -e py3passes (518 passed)change the walk repeats the same two paths indefinitely and never
reaches the regular file next to the symlink; after it, the walk
terminates and records the symlink as a link with its target