Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CRC-64/NVME, the 64 bit counterpart to the existing
crc32c, in both apure Python and a native Rust implementation.
The layout follows
crc32cexactly, sodissect.util.hash.crc64cresolves tothe native version when the extension is available and falls back to Python
otherwise, with
crc64c_nativeandcrc64c_pythonavailable for picking oneexplicitly.
Parameters are polynomial
0xAD93D23594C93659, reflected, with all-ones initand xorout.
Test plan
tox run -e py3passes (163 passed, 63 skipped)crc64c(b"123456789") == 0xae8b14860a799888implementation rather than only against itself
updates composed via the
valueargumentcrc64cfixture runs every case against bothimplementations, matching how
crc32cis tested