Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading to EOF on an
OverlayStreamwith no known size usedsys.maxsizeasthe read length. That works on a
BytesIO, but a real file object raisesOverflowError: byte string is too large.Determine the actual end instead, by seeking the source to EOF and taking the
maximum of that and the end of every registered overlay, so an overlay that
extends past the end of the source stream is still fully read.
Fixes #114
Test plan
tox run -e py3passes (161 passed)BytesIOin anio.BufferedReaderso theOverflowErrorreproduces in memory, matching how the existing testsavoid touching the filesystem