feat(runs): apply the run base dir and raw data path settings - #8026
Open
davidlin20dev wants to merge 3 commits into
Open
davidlin20dev wants to merge 3 commits into
davidlin20dev wants to merge 3 commits into
Conversation
Signed-off-by: davidlin20dev <davidlin20.dev@gmail.com>
Signed-off-by: davidlin20dev <davidlin20.dev@gmail.com>
Signed-off-by: davidlin20dev <davidlin20.dev@gmail.com>
3 tasks
popojk
reviewed
Sep 16, 2026
| concurrency.GetState() == settings.SettingState_SETTING_STATE_VALUE { | ||
| spec.MaxActionConcurrency = uint32(concurrency.GetIntValue()) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Could we also validate the format of storage path here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #7775 and #7932. Covers task 3.4 in
CreateRun:storage.raw_data_pathin full,run.run_base_dirfor run metadata.UploadInputsdoes not read settings yet, so offloaded inputs still use the cluster default. That half is a separate PR.Why are the changes needed?
run.run_base_dirandstorage.raw_data_pathcan be stored and resolved, but nothing reads them, so a run's storage paths still come only from the request or the cluster-wide default. An admin cannot point a project's run data at their own bucket.What changes were proposed in this pull request?
applyRunSettingsfillsRunSpec.run_base_dirandRunSpec.raw_data_storage.raw_data_prefixwhen the request leaves them unset. An explicit request value always wins, and a setting that is INHERIT or UNSET contributes nothing.CreateRunneeds no logic change. It already reads both fields and falls back to the configured prefix, andapplyRunSettingsruns before that, so the request, then settings, then config precedence holds without any extra code.CreateRunasked for exactly this and is narrowed to the remaining gap; the one inUploadInputspointed atStorageSettings.run_base_dir, which isreservedand no longer exists, and claimedCreateRunstill needed the work.How was this patch tested?
applyRunSettingstable, covering both fields: the setting is applied, an explicit request value wins, and INHERIT and UNSET contribute nothing. One row sendsRawDataStoragepresent but with an empty prefix, which must still take the setting.runs/serviceanddataproxy/servicetests pass unchanged.Labels
Check all the applicable boxes