refactor settings api to be simpler and more type safe - #7127
Merged
Merged
Conversation
afbrock
force-pushed
the
adam/simpler_settings_api
branch
from
April 1, 2026 18:15
276a4bf to
d1b4565
Compare
afbrock
force-pushed
the
adam/simpler_settings_api
branch
2 times, most recently
from
April 1, 2026 23:10
9d79bbf to
869166d
Compare
EngHabu
approved these changes
Apr 2, 2026
Comment on lines
+33
to
+35
| extend google.protobuf.FieldOptions { | ||
| string desc = 50000; | ||
| } |
| // SettingState controls how a setting at a given scope behaves when no value | ||
| // is set. The VALUE state is implicit: it is inferred from which value field | ||
| // inside the SettingValue oneof is populated. | ||
| // desc is a field option that attaches a human-readable description to a |
Contributor
There was a problem hiding this comment.
I think you can create a "settings" directory... and move these two files to it, so your types can be Int64 instead of Int64Setting
afbrock
force-pushed
the
adam/simpler_settings_api
branch
2 times, most recently
from
April 3, 2026 02:37
dc9aa47 to
3370e89
Compare
Signed-off-by: Adam Brock <adam@union.ai>
afbrock
force-pushed
the
adam/simpler_settings_api
branch
from
April 3, 2026 18:29
3370e89 to
304b374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The previous API was clunky when we went to start using it, so before it gets any adoption we are changing the interface to be simpler, easier to understand and use, and type safe.
What changes were proposed in this pull request?
This PR removes the 'raw' unstructured APIs and instead only allows get/getForEdit/Update using the structured and typed settings message.
How was this patch tested?
Unit tests and devbox testing with the included buf curl scripts. (along with the cloud pr: https://github.com/unionai/cloud/pull/15164 )
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main