[share_plus] Remove usage of deprecated UIApplication.keyWindow in iOS 13+ - #1157
Merged
miquelbeltran merged 2 commits intoOct 5, 2022
Merged
Conversation
daniel-shuy
force-pushed
the
keywindow-deprecated
branch
from
October 4, 2022 15:30
88cf4ac to
e7f1e08
Compare
miquelbeltran
approved these changes
Oct 5, 2022
|
I get the same issue: ` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UIApplication.keyWindowis deprecated in iOS 13+, leading to iOS 13+ applications built with theshare_plusplugin to emit deprecation warnings on build. In addition,UIApplication.keyWindowis not guaranteed to work in the future.This PR changes the
RootViewController()function to check if the iOS version is>13, and if so, uses the new approach instead ofUIApplication.keyWindow.See https://stackoverflow.com/questions/57134259/how-to-resolve-keywindow-was-deprecated-in-ios-13-0#answer-58031897 for more information.
I have tested this change using the
share_plusexample on the iOS Simulator.Related Issues
Fixes #917
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?