[share_plus] temporary XFiles directory not cleaned

[Coronon]

Platform

All

Plugin

share_plus

Version

>= 4.50

Flutter SDK

Any

Steps to reproduce

This is not really a ‘bug’ as in something is not working for the user, but as in undesirable behaviour.

Simply use shareXFiles without the files already having a path e.g. using XFile.fromData and experience your apps needed storage to increase by the filesize. While not having experienced this with share_plus, I used a similar approach for one of my apps lately. One would expect that the OS cleans up temporary storage - but it really does not until absolutely necessary, easily getting an app to a few GB.

The offending code lives in Future<List<XFile>> _getFiles(List<XFile> files), which is also why we refrained from providing the user with a way to pass raw bytes instead of handling a file himself before version 4.5.0.

Code Sample

No response

Logs

n.a.

Flutter Doctor

n.a.

Checklist before submitting a bug

• I Google'd a solution and I couldn't find it
• I searched on StackOverflow for a solution and I couldn't find it
• I read the README.md file of the plugin
• I'm using the latest version of the plugin
• All dependencies are up to date with flutter pub upgrade
• I did a flutter clean
• I tried running the example project

[miquelbeltran]

Yeah, I pointed that up when the PR was submitted, but as far as I understand, the use of the cache/temp directory is correct:

https://pub.dev/documentation/path_provider/latest/path_provider/getTemporaryDirectory.html

I think documenting this and reminding devs to clean this directory up once in a while when using shareXFile without paths would be enough.