Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit f0126f3): https://flutter-docs-prod--docs-pr13558-feat-blog-drugp8f0.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit f0126f3): https://flutter-dev-230821--www-pr13558-feat-blog-aajb5l2g.web.app |
|
To be honest, I don't like blog systems without comment features. |
Thanks for the feedback! Once our blogs are both migrated and given some time in production, depending on community feedback, we might consider investigating support for comments and/or reactions. It requires additional planning, work, and process due to involving user data, so we won't be including support as part of this initial implementation. In the mean time, blog posts can be (and often are) discussed on some of the great Flutter communities or on social media. |
|
Thanks for the hard work on this @schultek! Just commenting a few issues, notes, and ideas from our discussion so they don't get lost:
Questions:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a new blog system, adding several UI components, data models, and Atom feed generation. It also updates the site layout to include improved social media meta tags and adds necessary dependencies for internationalization and XML processing. The code review identified several critical runtime issues, specifically regarding YAML map parsing, frontmatter date handling, and page filtering logic that could cause build crashes. Additionally, a null-safety improvement for the clipboard API was suggested. All review comments are actionable and address potential stability and safety issues; therefore, no comments were removed.
# Conflicts: # packages/site_shared/lib/src/layouts/dash_layout.dart # packages/site_shared/pubspec.yaml # sites/www/lib/src/style_hash.dart
|
@parlough - can you check the build failure? I am reviewing this now as well! |
|
I'm looking into this right now. The build fails as part of this workflow, but succeeds for the deployment job which is a bit strange. |
|
All green now. @abdallahshaban557 @parlough Once you approve I would merge this. 🚀 |
|
@parlough - can we have the date and reading time wrap to a new line always, similar to what is shown in the left hand image I am attaching for consistency? |
|
@parlough - another build failure it seems |
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks for the hard work on this @schultek! Do wait for @abdallahshaban557 to approve before landing.
If anything else comes up, we can follow with those improvements before we update the blog.flutter.dev redirects.
6 participants
Implements the Flutter Blog as part of the marketing site using Jaspr.
sites/www/content/blog.sites/www/content/blog/authors.yaml.Preview: https://flutter-dev-230821--www-pr13558-feat-blog-aajb5l2g.web.app/blog
Contributes to #13507