This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[tool] Don't add Guava in the all-packages app - #6747
Merged
stuartmorgan-g merged 3 commits intoJan 9, 2023
Merged
Conversation
It's not clear why we are adding an outdated version of Guava; it is likely cruft, so this test removing it.
tarrinneal
approved these changes
Jan 7, 2023
tarrinneal
left a comment
Contributor
There was a problem hiding this comment.
Guava's aren't that good anyway
Contributor
Author
|
Landing on red to try to green the tree (it's red on scheduling issues) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear why we are adding an outdated version of Guava; it is likely cruft, so this tests removing it.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).