Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tool] Don't add Guava in the all-packages app - #6747

Merged
stuartmorgan-g merged 3 commits into
flutter-team-archive:mainfrom
stuartmorgan-g:tool-create-all-app-remove-guava
Jan 9, 2023
Merged

[tool] Don't add Guava in the all-packages app#6747
stuartmorgan-g merged 3 commits into
flutter-team-archive:mainfrom
stuartmorgan-g:tool-create-all-app-remove-guava

Conversation

@stuartmorgan-g

@stuartmorgan-g stuartmorgan-g commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

It's not clear why we are adding an outdated version of Guava; it is likely cruft, so this tests removing it.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@tarrinneal tarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guava's aren't that good anyway

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2023
@stuartmorgan-g

Copy link
Copy Markdown
Contributor Author

Landing on red to try to green the tree (it's red on scheduling issues)

@stuartmorgan-g
stuartmorgan-g merged commit d03de2f into flutter-team-archive:main Jan 9, 2023
@stuartmorgan-g
stuartmorgan-g deleted the tool-create-all-app-remove-guava branch January 9, 2023 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants