support json gem v3.x - #5492
Merged
Merged
Conversation
Contributor
Author
|
The codes in fluentd/lib/fluent/command/cat.rb Line 329 in 0cf5f23 |
json 3.0 dropped the positional options argument from JSON.parse, so every call passing Fluent::DEFAULT_JSON_PARSE_OPTIONS now fails with ArgumentError: wrong number of arguments (given 2, expected 1). This breaks fluentd at startup because the config parser cannot read any JSON literal. Pass the options as keyword arguments instead, which works with both json 2.21 and 3.0. JSON::ResumableParser still accepts a positional hash, but switch it over as well so that the constant is always passed the same way. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
fix-json3-keyword-args
branch
from
September 9, 2026 05:49
a7fe4a1 to
83e9a6a
Compare
Watson1978
changed the title
Watson1978
added
the
backport to v1.19
kenhys
approved these changes
Sep 9, 2026
Watson1978
added a commit
that referenced
this pull request
Sep 9, 2026
json 3.0 dropped the positional options argument from JSON.parse, so every call passing Fluent::DEFAULT_JSON_PARSE_OPTIONS now fails with ArgumentError: wrong number of arguments (given 2, expected 1). This breaks fluentd at startup because the config parser cannot read any JSON literal. Pass the options as keyword arguments instead, which works with both json 2.18 and 3.0. Backport of #5492. The JSON::ResumableParser changes are omitted since that class is not used in this branch. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
added a commit
that referenced
this pull request
Sep 9, 2026
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: json 3.0 dropped the positional options argument from `JSON.parse`, so every call passing `Fluent::DEFAULT_JSON_PARSE_OPTIONS` now fails with `ArgumentError: wrong number of arguments (given 2, expected 1)`. Ref. https://github.com/fluent/fluentd/actions/runs/34311091836 Pass the options as keyword arguments instead. **Docs Changes**: N/A **Release Note**: * Support json gem v3.x Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
pushed a commit
that referenced
this pull request
Sep 10, 2026
**Which issue(s) this PR fixes**: Backport #5492 Fixes # **What this PR does / why we need it**: json 3.0 dropped the positional options argument from `JSON.parse`, so every call passing `Fluent::DEFAULT_JSON_PARSE_OPTIONS` now fails with `ArgumentError: wrong number of arguments (given 2, expected 1)`. Ref. https://github.com/fluent/fluentd/actions/runs/34311091836 Pass the options as keyword arguments instead. **Docs Changes**: N/A **Release Note**: * Support json gem v3.x Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
json 3.0 dropped the positional options argument from
JSON.parse, so every call passingFluent::DEFAULT_JSON_PARSE_OPTIONSnow fails withArgumentError: wrong number of arguments (given 2, expected 1).Ref. https://github.com/fluent/fluentd/actions/runs/34311091836
Pass the options as keyword arguments instead.
Docs Changes:
N/A
Release Note: