Skip to content

Fix zsh completion panic - #161

Merged
djc merged 3 commits into
flamegraph-rs:mainfrom
ede1998:fix-zsh-completion-panic
Oct 25, 2021
Merged

djc merged 3 commits into
flamegraph-rs:mainfrom
ede1998:fix-zsh-completion-panic

Conversation

@ede1998

@ede1998 ede1998 commented Oct 16, 2021

Copy link
Copy Markdown
Contributor

Closes #158.

What changed:

  • remove conflicts_with = "hash" and conflicts_with = "no-sort". They only exist in inferno's Options` struct, but they are not valid CLI argument.
  • remove conflicts_with = "freq" and replace it with a manual check. This is a bit of a workaround to fix the completion gen panic. Maybe we can remove that again in the future.
  • Fix a small clippy warning I ran into.

@djc
djc merged commit b397d67 into flamegraph-rs:main Oct 25, 2021
@djc

djc commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

Nice, thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flamegraph --completions zsh crashes

2 participants