Skip to content

Bump minSdk to 24 - #8560

Merged
emilypgoogle merged 5 commits into
mainfrom
ep/min-sdk-24
Sep 9, 2026
Merged

Bump minSdk to 24#8560
emilypgoogle merged 5 commits into
mainfrom
ep/min-sdk-24

Conversation

@emilypgoogle

Copy link
Copy Markdown
Contributor

Adjusts testing config and minSdk variables to use Android 23. Not to be merged until the next breaking release.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@google-oss-bot

Copy link
Copy Markdown
Collaborator

Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR or 'NO_RELEASE_CHANGE' to the description to silence this warning.)

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@milaGGL

milaGGL commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported Android SDK version from 23 to 24 across several Firebase modules, simplifying codebase logic by removing legacy API 23 compatibility paths and associated tests. The feedback highlights that in multiple firebase-storage test files, switching to Config.OLDEST_SDK targets an API level lower than the new minimum SDK of 24. It is recommended to explicitly pin these tests to sdk = 24 or remove the sdk parameter entirely to avoid running tests on unsupported platform versions.

Comment thread firebase-dataconnect/demo/build.gradle.kts
milaGGL
milaGGL previously approved these changes Sep 8, 2026
@emilypgoogle
emilypgoogle merged commit e83cb8f into main Sep 9, 2026
330 of 338 checks passed
@emilypgoogle
emilypgoogle deleted the ep/min-sdk-24 branch September 9, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants