Repository navigation
chore(deps): bump cloud.google.com/go/storage to v1.68.0 - #790
Open
hypergadam wants to merge 1 commit into
Open
hypergadam wants to merge 1 commit into
hypergadam wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds .idea to the .gitignore file and updates several Go dependencies in go.mod and go.sum, including upgrading cloud.google.com/go/storage and google.golang.org/api. There are no review comments, and I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
cloud.google.com/go/storagefrom v1.62.1 to v1.68.0.This is routine dependency maintenance — no source files change.
What moves
cloud.google.com/go/storagegoogle.golang.org/apicloud.google.com/go/longrunninggithub.life-white.uk/googleapis/gax-go/v2github.life-white.uk/googleapis/enterprise-certificate-proxygolang.org/x/cryptogolang.org/x/netgoogle.golang.org/genproto/....../opentelemetry-operations-go/exporter/metric.../opentelemetry-operations-go/internal/resourcemappinggoogle.golang.org/apiis a direct dependency and moves as part of thisbump — storage v1.68.0 requires the newer version via MVS, so the two cannot be
separated. Flagging it explicitly since it is a larger surface than the storage
bump alone.
On the deprecated OpenTelemetry modules
This PR does not remove the deprecated
GoogleCloudPlatform/opentelemetry-operations-gomodules, in case that questioncomes up. They remain required transitively and cannot be dropped from this
repo:
exporter/metricis a direct requirement ofcloud.google.com/go/storageitself (consumed in its
grpc_metrics.go), still present at v1.68.0.detectors/gcpis a direct requirement of its own suggested replacement,go.opentelemetry.io/contrib/detectors/gcp.Neither module is imported by any package in this repository — both carry
// indirect. Removing them would require changes upstream ingoogleapis/google-cloud-goandopen-telemetry/opentelemetry-go-contrib.Discussion
CONTRIBUTING.md).than a behavioral change. Happy to open an issue first if maintainers
prefer that for dependency bumps.
Testing
go build ./...andgo vet ./...both clean.source changes and no new behavior to cover.
Unit suites (
auth,db,messaging,storage,remoteconfig,appcheck,iid,internal,phonenumberverification,auth/hash) all pass.The
integration/*suites fail locally for lack of credentials(
testdata/integration_cert.json) and a project ID. Verified this failure set isidentical on
masterbefore the change, so it is environmental and not aregression from this bump.
API Changes
None. No public API is affected — the change is confined to
go.modandgo.sum.